GitHub action to setup Helm chart with appVersion for deployment - #3
Merged
stplasim merged 6 commits intoMar 5, 2025
Merged
Conversation
alexlanz
approved these changes
Mar 1, 2025
Comment on lines
+56
to
+60
| - name: Extract Helm chart | ||
| shell: bash | ||
| working-directory: ${{ inputs.working-directory }} | ||
| run: | | ||
| tar -xzf ${{ inputs.helm-package }}-*.tgz |
Member
There was a problem hiding this comment.
Oh wow, is this really a required step. 🤯
Contributor
Author
There was a problem hiding this comment.
We only need this step because we want to set the app version to the commit hash. If we didn't set this or left it at a fixed value, we could omit this and the pull step and specify the OCI image directly when upgrading. But as I said, without the app version it is relatively difficult to find the deployment again
Co-authored-by: Alex Lanz <alex.lanz@aboutbits.it>
…lm-chart-with-appversion-for' into ab-353-github-action-to-setup-helm-chart-with-appversion-for
stplasim
deleted the
ab-353-github-action-to-setup-helm-chart-with-appversion-for
branch
March 5, 2025 10:50
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.